Hi Krzysztof, On Fri, Jan 24, 2025 at 09:22:54AM +0100, Krzysztof Kozlowski wrote: > On Fri, Jan 24, 2025 at 09:19:49AM +0100, Krzysztof Kozlowski wrote: > > On Wed, Jan 22, 2025 at 11:24:33AM +0100, Markus Schneider-Pargmann wrote: > > > Add compatible for ti,am62-ddr-pmctrl to the list. There is a DDR pmctrl > > > register in the wkup-conf register space of am62a and am62p. This > > > register controls DDR power management. > > > > > > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Un-acked, I missed the point that you really speak in commit msg about > register and you really treat one register is a device. I assumed you > only need that register from this device, but no. That obviously is not > what this device is. Device is not a single register among 10000 others. > IOW, You do not have 10000 devices there. Do I understand you correctly that the whole register range of the wkup_conf node as seen in arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi should be considered a single syscon device? Unfortunately wkup_conf is modeled as a simple-bus with currently 5 subnodes defined of which 4 of them consist of a single register. Most of them are syscon as well. So I think I can't change the simple-bus back to syscon. For the DDR pmctrl, this really only consist of a single register, the registers surrounding this pmctrl are not related as far as I can tell. What do you suggest how I can solve this? Best Markus > > So: > > NAK > > Best regards, > Krzysztof >
Attachment:
signature.asc
Description: PGP signature
