> > The difference is probably caused by memcpy() vs memcpy_fromio(). The > > comment above memcpy_fromio() says "This needs to be optimized". I think > > generally speaking memcpy_fromio() is correct for a framebuffer. > > > > That said, if the fb is in RAM, and is only written by the CPU, I think > > a normal memcpy() for fb_memcpy_fromfb() should be fine... > > Could memcpy() cause alignment traps here if the fb pointer is unaligned > and uncached? Original commit did not comment on any failure, so I expect that is not a problem here... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html