Re: [PATCH 1/5] arm64: dts: renesas: r8a779f0: Add labels for rswitch ports

Marek Vasut <marek.vasut@xxxxxxxxxxx> · Thu, 23 Jan 2025 17:20:22 +0100

On 1/23/25 4:25 PM, Geert Uytterhoeven wrote:
Hi Marek,

Hi,

On Sat, Jan 18, 2025 at 12:14 PM Marek Vasut
<marek.vasut+renesas@xxxxxxxxxxx> wrote:
Introduce labels for each rswitch port in the form 'rswitchportN'.
Those can be used to access rswitch port nodes directly, which is
going to be useful in reducing DT indentation slightly as well as
in DT /aliases node to reference the rswitch ports as ethernetN
interfaces. No functional change.

Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.15.

--- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi
@@ -974,15 +974,15 @@ ethernet-ports {
                                 #address-cells = <1>;
                                 #size-cells = <0>;

-                               port@0 {
+                               rswitchport0: port@0 {
                                         reg = <0>;
                                         phys = <&eth_serdes 0>;
                                 };
-                               port@1 {
+                               rswitchport1: port@1 {
                                         reg = <1>;
                                         phys = <&eth_serdes 1>;
                                 };
-                               port@2 {
+                               rswitchport2: port@2 {
                                         reg = <2>;
                                         phys = <&eth_serdes 2>;
                                 };

Would you mind if I would change all rswitchportN to rswitch_portN
while applying, for consistency with other Renesas DTS files?
Go ahead, but also keep the commit messages in sync .

I can send a V2 too ?







