On 22.01.2025 11:14 AM, Nirmesh Kumar Singh wrote: > Add DTS support for Qualcomm qcs6490-rb3gen2 industrial mezzanine board. > > Signed-off-by: Sahil Chandna <quic_chandna@xxxxxxxxxxx> > Signed-off-by: Nirmesh Kumar Singh <quic_nkumarsi@xxxxxxxxxxx> > > --- [...] > +&spi11 { > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > + > + st33htpm0: tpm@0 { > + compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi"; > + reg = <0>; > + spi-max-frequency = <20000000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&tpm_spi_reset>; Apart from Dmitry's comments, please keep pinctrl-n above pinctrl-names for style uniformity Konrad