Hi Iwamatsu-san,
On Thu, Jan 16, 2025 at 3:48 PM Nobuhiro Iwamatsu <iwamatsu@xxxxxxxxxxx> wrote:
> Add basic support for Yuridenki-Shokai Kakip board based on R9A09G057H48.
> This commit supports the following:
>
> - Memory
> - Input clocks
> - Pin Control
> - SCIF
> - OSTM0 - OSTM7
> - SDHI0
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@xxxxxxxxxxx>
>
> ---
> v2: Drop bootargs from chosen.
> Fix binding name for regulators.
> Fix the name style of the regulator.
> Use DTS coding style.
Thanks for the update!
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057h48-kakip.dts
> +/ {
> + vqmmc_sdhi0: regulator-vccq-sdhi0 {
> + compatible = "regulator-gpio";
> + regulator-name = "SDHI0 VccQ";
> + gpios = <&pinctrl RZV2H_GPIO(A, 0) GPIO_ACTIVE_HIGH>;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpios-states = <0>;
> + states = <3300000 0 1800000 1>;
"states = <3300000 0>, <1800000 1>;", as these are two tuples.
> + };
> +};
> +
> +&qextal_clk {
> + clock-frequency = <24000000>;
> +};
> +
> +&pinctrl {
Please sort nodes alphabetically.
> +&scif {
> +};
> +
> +&ostm0 {
Likewise.
The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-devel for v6.15, with the above fixed.
No need to resend.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
