On Wed, Jan 22, 2025 at 03:20:39PM +0200, Alisa-Dariana Roman wrote: > + adi,odr-state: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Should be present if ODR pins are pin-strapped. Value corresponds to: > + 0: 120 Hz (ODR1=0, ODR2=0) > + 1: 60 Hz (ODR1=0, ODR2=1) > + 2: 50 Hz (ODR1=1, ODR2=0) > + 3: 10 Hz (ODR1=1, ODR2=1) > + If defined, odr-gpios must be absent. > + enum: [0, 1, 2, 3] This should be a property in hertz > + pga-gpios: > + description: | > + PGA1 and PGA2 pins for gain selection. Should be defined if adi,pga-state > + is absent. > + maxItems: 2 > + > + adi,pga-state: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Should be present if PGA pins are pin-strapped. Value corresponds to: > + 0: Gain 1 (PGA1=0, PGA2=0) > + 1: Gain 8 (PGA1=0, PGA2=1) > + 2: Gain 64 (PGA1=1, PGA2=0) > + 3: Gain 128 (PGA1=1, PGA2=1) > + If defined, pga-gpios must be absent. > + enum: [0, 1, 2, 3] And I think this one should be in units of "gain". > + adi,clksel-state: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Should be present if CLKSEL is pin-strapped. 0 selects an external clock, > + 1 selects the internal clock. If defined, clksel-gpios must be absent. > + enum: [0, 1] IMO this one should be a string, options of "external" and "internal". 0 & 1 means nothing to a dts reader/author and needs to be cross checked with the binding to obtain the meanings.
Attachment:
signature.asc
Description: PGP signature
