Re: [RFC PATCH 01/10] dt-bindings: net: ti: Adds device tree binding for DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 22, 2025 at 06:56:14PM +0530, Basharath Hussain Khaja wrote:
> 
> >> +          ti,no-half-duplex:
> >> +            type: boolean
> >> +            description:
> >> +              Disable half duplex operation on ICSSM MII port.
> > 
> > I already asked this in the next patch, but why have this property? Is
> > it because the hardware is broken? Or is this some sort of policy?
> > Policy should not be in DT, DT describes the hardware, not the policy
> > of how you use the hardware.
> > 
> 
> This series of patches enables support for full-duplex only. Support for 
> half-duplex will be added in subsequent revisions. We will clean it up in
> the next version.

So you don't need this property. All you need to do is remove the 1/2
duplex link modes using phy_remove_link_mode() and user space will not
get the option to enable them, not will auto-neg advertise them.

	Andrew




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux