[no subject]

**Date** **Thread**

We'll drop this dt-binding header, ad move it to the dts folder.

> > > > @@ -0,0 +1,1415 @@
> > > 
> > > 1415 ?Â  90% seem unnecessary.
> > > 
> > > > +
> > > > +/* GCE thread priority */
> > > > +#define CMDQ_THR_PRIO_LOWESTÂ Â  0
> > > > +#define CMDQ_THR_PRIO_1Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  1
> > > > +#define CMDQ_THR_PRIO_2Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  2
> > > > +#define CMDQ_THR_PRIO_3Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  3
> > > > +#define CMDQ_THR_PRIO_4Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  4
> > > > +#define CMDQ_THR_PRIO_5Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  5
> > > > +#define CMDQ_THR_PRIO_6Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  6
> > > > +#define CMDQ_THR_PRIO_HIGHESTÂ  7
> > > > 
> > > Â Only need to HIGHEST maybe
> > 
> > Or maybe we could just get rid of them and describe the valid
> > values
> > and ordering in the YAML part?

But actually, even if we describe this in the YAML, most of the GCE
users still won't know what is the meaning of each mbox-cells.

So I think if we can keep these define to make dts more readable.
What do you think?

> > 
> > > > +
> > > > +/* GCE subsys table */
> > > > +#define SUBSYS_1300XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  0
> > > > +#define SUBSYS_1400XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  1
> > > > +#define SUBSYS_1401XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  2
> > > > +#define SUBSYS_1402XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  3
> > > > +#define SUBSYS_1502XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  4
> > > > +#define SUBSYS_1880XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  5
> > > > +#define SUBSYS_1881XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  6
> > > > +#define SUBSYS_1882XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  7
> > > > +#define SUBSYS_1883XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  8
> > > > +#define SUBSYS_1884XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  9
> > > > +#define SUBSYS_1000XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  10
> > > > +#define SUBSYS_1001XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  11
> > > > +#define SUBSYS_1002XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  12
> > > > +#define SUBSYS_1003XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  13
> > > > +#define SUBSYS_1004XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  14
> > > > +#define SUBSYS_1005XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  15
> > > > +#define SUBSYS_1020XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  16
> > > > +#define SUBSYS_1028XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  17
> > > > +#define SUBSYS_1700XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  18
> > > > +#define SUBSYS_1701XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  19
> > > > +#define SUBSYS_1702XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  20
> > > > +#define SUBSYS_1703XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  21
> > > > +#define SUBSYS_1800XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  22
> > > > +#define SUBSYS_1801XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  23
> > > > +#define SUBSYS_1802XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  24
> > > > +#define SUBSYS_1804XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  25
> > > > +#define SUBSYS_1805XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  26
> > > > +#define SUBSYS_1808XXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  27
> > > > +#define SUBSYS_180aXXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  28
> > > > +#define SUBSYS_180bXXXXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â  29
> > > > +#define SUBSYS_NO_SUPPORTÂ Â Â Â Â  99
> > > > +
> > > Keep only that you use now or plan inÂ  the near future. But ok.

I think we can drop this in MT8196 because GCE hardware designer didn't
change these subsys id from the previous SoCs.

Almost all of the device register are over 0x3000_0000, so it's no
longer to use in MT8196.

> > > 
> > > > +/* GCE-D hardware events */
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF0Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  0
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF1Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  1
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF2Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  2
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF3Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  3
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF4Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  4
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF5Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  5
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF6Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  6
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF7Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  7
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF8Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  8
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF9Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  9
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF10Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  10
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF11Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  11
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF12Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  12
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF13Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  13
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF14Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  14
> > > > +#define
> > > > CMDQ_EVENT_DISP0_STREAM_SOF15Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  15
> > > > 
> > > Â you mean
> > > Â  #define CMDQ_EVENT_DISP0_STREAM_SOF(n)Â  n

Yes, it's the same meaning.

[snip]

> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_WDMA0_TARGET_LINE_END_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  32
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_WDMA0_SW_RST_DONE_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  33
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_POSTMASK1_RST_DONE_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  34
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_POSTMASK0_RST_DONE_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  35
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_TIMEOUT_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  36
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT0Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  37
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT1Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  38
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT2Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  39
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT3Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  40
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT4Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  41
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT5Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  42
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT6Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  43
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT7Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  44
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT8Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  45
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT9Â Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  46
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT10Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  47
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT11Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  48
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT12Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  49
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT13Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  50
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT14Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  51
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT15Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  52
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MUTEX0_GET_RELEASE_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  53
> > > > +#define
> > > > CMDQ_EVENT_DISP0_DISP_MDP_RDMA0_SW_RST_DONE_ENG_EVENTÂ Â Â Â Â Â Â Â Â Â 
> > > > Â Â Â Â Â Â Â  54
> > > > +
> > > Â keep only the used ones and use
> > 
> > This is the only publicly available table of the numbers. Having
> > the complete table somewhere would be nice. OOTH the numbers being
> > like IRQ or DRQ numbers, don't actually get used in the driver.
> > So maybe we could keep the full list but move it under the dts
> > directory?
> > 
> Why introduce bloat in the kernel? We shouldn't be carrying what are
> basically 'addition' tables, not even 'multiplication' ;)
> The same knowledge can be represented concisely by the formula
> Â  #define CMDQ_EVENT_DISP0_DISP_MUTEX0_REG_UPDATE_ENG_EVENT(n)Â  (n +
> 37)
> especially for ~50 char defines
> 
> thnx

I agree with you, I'll simplify the define with post-fixed numbers, and
move it to dts folder once the mt8196.dtsi with gce node is submitted.

Thanks for your suggestion.

Regards,
Jason-JH Lin