On 21/01/2025 13:09, Vikram Sharma wrote: > This patch change clock names to make it consistent with Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > existing platforms as gcc_cam_hf_axi -> gcc_axi_hf. Which ones? sm8250 uses different. > This also adds gcc_axi_sf and remove gcc_camera_ahb. Why? > > This change will not break ABI because the ABI hasn't > been cemented yet as the dtsi changes are not merged > yet and there are no users for this driver as of now. So why did you wait till it gets to this merge window? Or is there some sort of history here which you hid? The user was merged to media tree and it is going to be merged for RC1. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Best regards, Krzysztof