On Mon, Jan 20, 2025 at 06:21:04PM +0100, Michal Wilczynski wrote: > reg: > maxItems: 1 > @@ -25,11 +30,8 @@ properties: > maxItems: 3 > > clock-names: > - items: > - - const: core > - - const: mem > - - const: sys > minItems: 1 > + maxItems: 3 So what is the third item? It cannot be anything, but must be constrained. I understand that you clean it up and maybe the cleaning is correct, but it should be separate commit with its own explanation. > > interrupts: > maxItems: 1 > @@ -47,8 +49,6 @@ required: > - clock-names > - interrupts > > -additionalProperties: false > - > allOf: > - if: > properties: > @@ -58,7 +58,28 @@ allOf: > then: > properties: > clocks: > + minItems: 1 Drop minItems here. > maxItems: 1 > + clock-names: > + items: > + - const: core > + > + - if: > + properties: > + compatible: > + contains: > + const: thead,th1520-gpu > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 > + clock-names: > + items: > + - const: core > + - const: sys > + > +unevaluatedProperties: false That's not explained. Does not look correct, either, unless you fix some issue, but then again: separate commit. Best regards, Krzysztof
