Hey Punnaiah- A few nitpicks here, in case you'll be spinning up a new version of your patchset. On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote: > Add pl353 static memory controller devicetree binding information. > > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx> [..] > @@ -0,0 +1,37 @@ > +Device tree bindings for ARM PL353 static memory controller > + > +PL353 static memory controller supports two kinds of memory > +interfaces. i.e NAND and SRAM/NOR interfaces. > +The actual devices are instantiated from the child nodes of pl353 smc node. > + > +Required properties: > +- compatible : Should be "arm,pl353-smc-r2p1" > +- reg : Controller registers map and length. > +- clock-names : List of input clock names - "memclk", "aclk" > + (See clock bindings for details). > +- clocks : Clock phandles (see clock bindings for details). Technically not clock phandles, but clock specifiers. > +- address-cells : Address cells, must be 1. > +- size-cells : Size cells. Must be 1. These should have the leading '#' as in '#address-cells' and '#size-cells'. Josh
Attachment:
pgpLdxaBcPZC1.pgp
Description: PGP signature
