On Mo, 2025-01-20 at 18:21 +0100, Michal Wilczynski wrote: > Add a YAML schema for the T-HEAD TH1520 SoC reset controller. This > controller manages resets for subsystems such as the GPU within the > TH1520 SoC. This mentions "resets", plural, but the #reset-cells = <0> below and the driver implementation look like there only is a single reset control (for the GPU). > > Signed-off-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > --- > .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > new file mode 100644 > index 000000000000..c15a80e00935 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD TH1520 SoC Reset Controller > + > +description: > + The T-HEAD TH1520 reset controller is a hardware block that asserts/deasserts > + resets for SoC subsystems. Again, plural. > + > +maintainers: > + - Michal Wilczynski <m.wilczynski@xxxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - thead,th1520-reset > + > + reg: > + maxItems: 1 > + > + "#reset-cells": > + const: 0 Should this be "const: 1" instead? regards Philipp
