On Mon, Jan 20, 2025 at 6:20 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote: > > Hi Jassi, > > On Tue, Dec 17, 2024 at 11:31:30AM +0000, Valentina Fernandez wrote: > ... > > This series adds support for the Microchip Inter-Processor Communication > > (IPC) mailbox driver. > ... > > Valentina Fernandez (4): > > riscv: sbi: vendorid_list: Add Microchip Technology to the vendor list > > riscv: export __cpuid_to_hartid_map > > dt-bindings: mailbox: add binding for Microchip IPC mailbox controller > > mailbox: add Microchip IPC support > > I see this series is now in next-20250120 but you only applied patches 3 > and 4, so the build is broken: > > In file included from drivers/mailbox/mailbox-mchp-ipc-sbi.c:22: > drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_sbi_chan_send': > drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function) > 29 | MICROCHIP_VENDOR_ID) > | ^~~~~~~~~~~~~~~~~~~ > arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall' > 436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e) > | ^ > drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY' > 121 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: note: each undeclared identifier is reported only once for each function it appears in > 29 | MICROCHIP_VENDOR_ID) > | ^~~~~~~~~~~~~~~~~~~ > arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall' > 436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e) > | ^ > drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY' > 121 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_sbi_send': > drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function) > 29 | MICROCHIP_VENDOR_ID) > | ^~~~~~~~~~~~~~~~~~~ > arch/riscv/include/asm/sbi.h:436:56: note: in definition of macro 'sbi_ecall' > 436 | __sbi_ecall(a0, a1, a2, a3, a4, a5, f, e) > | ^ > drivers/mailbox/mailbox-mchp-ipc-sbi.c:134:25: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY' > 134 | ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, address, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function 'mchp_ipc_probe': > drivers/mailbox/mailbox-mchp-ipc-sbi.c:29:42: error: 'MICROCHIP_VENDOR_ID' undeclared (first use in this function) > 29 | MICROCHIP_VENDOR_ID) > | ^~~~~~~~~~~~~~~~~~~ > drivers/mailbox/mailbox-mchp-ipc-sbi.c:420:35: note: in expansion of macro 'SBI_EXT_MICROCHIP_TECHNOLOGY' > 420 | ret = sbi_probe_extension(SBI_EXT_MICROCHIP_TECHNOLOGY); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Can you please fix this? It is a little frustrating this is happening > just as the merge window opens... > Usually the platform specific stuff goes via the platform tree, for example there isn't anything 'mailbox' about MICROCHIP_VENDOR_ID and __cpuid_to_hartid_map. I pick only mailbox patches unless the maintainer acks and wants me to pick platform ones. Though I should have noted that I am picking only mailbox stuff, but ok I will queue them now. Thnx
