Hi Quentin,
On 1/16/25 15:47, Quentin Schulz wrote:
> This adds minimal support for the Pre-ICT tester adapter for RK3588
> Jaguar.
> GPIO3A3, GPIO3A4, GPIO3B2 and GPIO3D2 to GPIO3D5 are all routed to power
> rails and can only be used as input and their bias are important to be
> able to properly detect soldering issues.
>
> Additionally, this adds build-time overlay application tests for (some)
> Rockchip overlays to try to avoid future regressions.
>
> Notably, the Device Trees from Wolfvision PF5 aren't migrated (but
> should) as I do not own the device and couldn't figure out from the
> introducing commit logs what the possible valid combinations are.
> +Cc Michael Riesch for awareness
Thanks for the heads up!
Just to make sure I understood correctly: By migrated you mean that the
overlay entries are moved to a separate section in the Makefile and
there are explicit combinations of base DTS and overlays for
compile-time testing purposes? If so, I don't consider the PF5 migration
as *that* urgent. I don't think you can break anything on our side. Or
am I missing something?
Maybe you can move the lines
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
to the overlay section as well? This should not cause any functional
changes.
> I'm wondering if we shouldn't backport patches 1 and 2 to stable? In
> which case, it would make sense to try to have the Wolfvision PF5
> overlay tests merged before the addition of the Pre-ICT tester adapter
> support for RK3588 Jaguar as that one won't be backported to stable and
> backporting the Wolfvision overlay test would incur an unnecessary
> (though not difficult) git conflict to resolve.
>
> I also do not know what kind of tests we should have when overlay
> combinations are possible (let's say there are A, B and C overlays that
> can all be applied, should we have base + A, base + B, base + C,
> base + A + B, base + A + C, base + B + C and base + A + B + C tests?
> maybe even base + B + A, base + C + B, base A + C + B, base + B + A + C,
> base + B + C + A, base + C + B + A and base + C + A + B tests?).
I have never been good at combinatorics, but I feel this has the
potential to explode :-) My two cents: The overlays *should* be
orthogonal to each other, i.e., no dependencies between them in the
sense that overlay A creates a node that is used by overlay B and that
sort of thing. Then
- Permutation can be ignored. (base + A + C = base + C + A)
- Composition (base + A + B + C) may be ignored in favor of individual
tests.
- Individual tests may be ignored in favor of (a) composition(s) that
cover(s) all individual tests.
But of course this is likely to vary from case to case. In our case, in
the composition
rk3568-wolfvision-pf5-vz-2-uhd := rk3568-wolfvision-pf5.dtb \
rk3568-wolfvision-pf5-io-expander.dtbo \
rk3568-wolfvision-pf5-display-vz.dtbo
would do the trick.
Thanks and regards,
Michael
>
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxx>
> ---
> Changes in v2:
> - add overlay application tests for Edgeble NCM6A WiFi and Rock 5B PCIe
> Endpoint+SNRS
> - add overlay application test for RK3588 Jaguar + Pre-ICT tester
> adapter,
> - Link to v1: https://lore.kernel.org/r/20241206-pre-ict-jaguar-v1-1-7f660bd4b70c@xxxxxxxxx
>
> ---
> Quentin Schulz (3):
> arm64: dts: rockchip: add overlay test for Edgeble NCM6A
> arm64: dts: rockchip: add overlay tests for Rock 5B PCIe overlays
> arm64: dts: rockchip: minimal support for Pre-ICT tester adapter for RK3588 Jaguar
>
> arch/arm64/boot/dts/rockchip/Makefile | 14 +-
> .../dts/rockchip/rk3588-jaguar-pre-ict-tester.dtso | 171 +++++++++++++++++++++
> 2 files changed, 182 insertions(+), 3 deletions(-)
> ---
> base-commit: 619f0b6fad524f08d493a98d55bac9ab8895e3a6
> change-id: 20241206-pre-ict-jaguar-b90fafee8bd8
>
> Best regards,
