Hello Rob On Wed, Apr 22, 2015 at 6:25 PM, Rob Herring <robherring2@xxxxxxxxx> wrote: >> This patch, replaces of_device_add() with platform_device_data(). > > This doesn't match the change. Thanks for catching it up. Will fix it and resend >> - if (of_device_add(dev) != 0) { >> + if (platform_device_add(dev) != 0) { > > Can't we now remove of_device_add? Now it is only used by ibmebus ricardo@neopili:~/linux-upstream$ git grep of_device_add arch/powerpc/kernel/ibmebus.c: ret = of_device_add(dev); drivers/of/device.c:int of_device_add(struct platform_device *ofdev) drivers/of/device.c: return of_device_add(pdev); include/linux/of_device.h:extern int of_device_add(struct platform_device *pdev); I think it can also use platform_device_add. I will prepare a patch to finally remove of_device_add() Thanks! -- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html