Re: [PATCH v7] serial: sc16is7xx: Add polling mode if no IRQ pin is available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2025 at 09:34:47AM +0100, Andre Werner wrote:
> Fall back to polling mode if no interrupt is configured because there
> is no possibility to connect the interrupt pin.
> 
> If no interrupt pin is available the driver uses a delayed worker to
> poll the state of interrupt status registers (IIR).

The commit message should be changed to reflect the code.
I.e. "Fix the IRQ check to treat the negative values as No IRQ."

> Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>

> Link: https://lore.kernel.org/r/20250110073104.1029633-2-andre.werner@xxxxxxxxxxxxxxxxxxxxx

This should not be here.

> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

It's not signed by Greg.

> V7:
> - Try to improve and unify comments as requested.
> - Fix typo in commit message: pull -> poll

Version should be 1 and Subject has to be changed accordingly.

...

> -	s->polling = !!irq;
> +	s->polling = (irq <= 0);

This is the only line has to be changed in the patch.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux