Hi, Krzysztof, Will send a new version soon, replying to confirm that I address the feedback received. On 12/22/24 8:44 AM, Krzysztof Kozlowski wrote: > On Fri, Dec 20, 2024 at 01:49:57PM +0000, Tudor Ambarus wrote: >> Add bindings for the Samsung Exynos Mailbox Controller. >> >> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> >> --- >> .../bindings/mailbox/google,gs101-mbox.yaml | 70 ++++++++++++++++++++++ >> include/dt-bindings/mailbox/google,gs101.h | 14 +++++ > > Drop the header, not used. not yet used in device tree indeed, will drop. I'll use driver definitions for specifying channel types. > >> 2 files changed, 84 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/google,gs101-mbox.yaml b/Documentation/devicetree/bindings/mailbox/google,gs101-mbox.yaml >> new file mode 100644 >> index 000000000000..a1fbc3b2b9de >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mailbox/google,gs101-mbox.yaml >> @@ -0,0 +1,70 @@ cut >> +description: | > > Drop | okay cut >> +examples: >> + # Doorbell mode. > > Drop comment, not applicable now, I think. okay. Thanks!