On 14/01/2025 22:59, Ivaylo Ivanov wrote:
> On 1/14/25 19:59, Krzysztof Kozlowski wrote:
>> On 09/01/2025 10:03, Ivaylo Ivanov wrote:
>>> static int exynos_usi_parse_dt(struct device_node *np, struct exynos_usi *usi)
>>> {
>>> int ret;
>>> @@ -251,6 +268,10 @@ static int exynos_usi_probe(struct platform_device *pdev)
>>> return PTR_ERR(usi->regs);
>>> }
>>>
>>> + ret = devm_add_action_or_reset(&pdev->dev, exynos_usi_unconfigure, usi);
>>> + if (ret)
>>> + return ret;
>> You should not reverse the action before the action actually takes place.
>>
>>> +
>>> ret = exynos_usi_configure(usi);
>>> if (ret)
>>> return ret;
>> Registering cleanup should therefore happen here.
>
> Alright, will fix. I'll try to submit the next (and hopefully final, if that's
> all the critique you have) version in the following days, but I'm currently
> focused on working on exynos2200.
Yeah, rest looks good. Anyway it is too late for this cycle, so I will
pick this (and everything else not picked up) after the merge window.
Best regards,
Krzysztof
