On Sat, Jan 04, 2025 at 10:58:54AM +0100, Krzysztof Kozlowski wrote: > On Fri, Jan 03, 2025 at 09:56:34PM +0000, Haylen Chu wrote: > > +#define CLK_PLL3_80 32 > > +#define CLK_PLL3_40 33 > > +#define CLK_PLL3_20 34 > > +#define CLK_APBS_NUM 35 > > Binding looks fine, thanks for the changes, but now I noticed this > define. Please drop. Number of clocks is rarely useful as a binding and > usually leading to ABI issues. > > Same for all other clock controllers below. Okay, will drop it. > > Best regards, > Krzysztof > Thanks, Haylen Chu