On Mon, Jan 13, 2025 at 06:40:13AM +0100, Dimitri Fedrau via B4 Relay wrote: > From: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx> > > Add support for changing the transmit amplitude voltage in 100BASE-TX mode. > Add support for configuration via DT. > > Signed-off-by: Dimitri Fedrau <dimitri.fedrau@xxxxxxxxxxxx> > --- > drivers/net/phy/dp83822.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c ... > @@ -197,6 +201,12 @@ struct dp83822_private { > bool set_gpio2_clk_out; > u32 gpio2_clk_out; > bool led_pin_enable[DP83822_MAX_LED_PINS]; > + int tx_amplitude_100base_tx_index; > +}; > + > +static const u32 tx_amplitude_100base_tx[] = { > + 1600, 1633, 1667, 1700, 1733, 1767, 1800, 1833, > + 1867, 1900, 1933, 1967, 2000, 2033, 2067, 2100, > }; > nit: The use of tx_amplitude_100base_tx seems to be protected by #ifdef CONFIG_OF_MDIO, so the definition of tx_amplitude_100base_tx probably should be too. Flagged by W=1 allmodconfig builds. ...