On Sun, 12 Jan 2025 15:25:36 +0300
Vasiliy Doylov via B4 Relay <devnull+nekodevelopper.gmail.com@xxxxxxxxxx> wrote:
> From: Vasiliy Doylov <nekodevelopper@xxxxxxxxx>
>
> This patch allows to read a mount-matrix device tree
> property and report to user-space or in-kernel iio clients.
>
> Signed-off-by: Vasiliy Doylov <nekodevelopper@xxxxxxxxx>
> ---
> drivers/iio/accel/mc3230.c | 28 ++++++++++++++++++++++++----
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/accel/mc3230.c b/drivers/iio/accel/mc3230.c
> index caa40a14a6316acae3a972f0ebe0b325db96eb44..a153a3f715ed7f2f1417618715767f265b49191d 100644
> --- a/drivers/iio/accel/mc3230.c
> +++ b/drivers/iio/accel/mc3230.c
> @@ -44,18 +44,34 @@ static const int mc3230_nscale = 115411765;
> .channel2 = IIO_MOD_##axis, \
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
> .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
> + .ext_info = mc3230_ext_info, \
> }
>
> +struct mc3230_data {
> + struct i2c_client *client;
> + struct iio_mount_matrix orientation;
> +};
> +
> +static const struct iio_mount_matrix *
> +mc3230_get_mount_matrix(const struct iio_dev *indio_dev,
> + const struct iio_chan_spec *chan)
> +{
> + struct mc3230_data *data = iio_priv(indio_dev);
> +
> + return &data->orientation;
> +}
> +
> +static const struct iio_chan_spec_ext_info mc3230_ext_info[] = {
> + IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, mc3230_get_mount_matrix),
> + {}
Trivial but if you are going around again for some other reason:
I'm (slowly) trying to standarize on { } (with a space) for these terminators in IIO.
> +};
> +
> static const struct iio_chan_spec mc3230_channels[] = {
> MC3230_CHANNEL(MC3230_REG_XOUT, X),
> MC3230_CHANNEL(MC3230_REG_YOUT, Y),
> MC3230_CHANNEL(MC3230_REG_ZOUT, Z),
> };
>
> -struct mc3230_data {
> - struct i2c_client *client;
> -};
> -
> static int mc3230_set_opcon(struct mc3230_data *data, int opcon)
> {
> int ret;
> @@ -141,6 +157,10 @@ static int mc3230_probe(struct i2c_client *client)
> if (ret < 0)
> return ret;
>
> + ret = iio_read_mount_matrix(&client->dev, &data->orientation);
> + if (ret)
> + return ret;
> +
> ret = iio_device_register(indio_dev);
> if (ret < 0) {
> dev_err(&client->dev, "device_register failed\n");
>
