Re: [PATCH v3 1/2] dt-bindings: iio: magnetometer: add binding for Si7210

[Jonathan Cameron <jic23@xxxxxxxxxx>]

On Sun, 12 Jan 2025 11:44:52 +0100
Antoni Pokusinski <apokusinski01@xxxxxxxxx> wrote:

> Silicon Labs Si7210 is an I2C Hall effect magnetic position
> and temperature sensor.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Antoni Pokusinski <apokusinski01@xxxxxxxxx>
Trivial comment inline. No need to change anything.

> ---
>  .../iio/magnetometer/silabs,si7210.yaml       | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml b/Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
> new file mode 100644
> index 000000000000..d4a3f7981c36
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/magnetometer/silabs,si7210.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Si7210 magnetic position and temperature sensor
> +
> +maintainers:
> +  - Antoni Pokusinski <apokusinski01@xxxxxxxxx>
> +
> +description: |
> +  Silabs Si7210 I2C Hall effect magnetic position and temperature sensor.
> +  https://www.silabs.com/documents/public/data-sheets/si7210-datasheet.pdf
> +
> +properties:
> +  compatible:
> +    const: silabs,si7210
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Regulator that provides power to the sensor
Not important, but this one is obvious enough I'd not have bothered with
the description text.
vdd-suppy: true
would have been fine.

Jonathan
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        magnetometer@30 {
> +            compatible = "silabs,si7210";
> +            reg = <0x30>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
> +            vdd-supply = <&vdd_3v3_reg>;
> +        };
> +    };