On 01/10, Marcelo Schmitt wrote:
> On 01/07, Jonathan Santos wrote:
> > From: Sergiu Cuciurean <sergiu.cuciurean@xxxxxxxxxx>
> >
> > This commit adds the ad7768_spi_reg_write_masked() which is a helper
> > function for writing specific bits inside a register, without interfering
> > with the other bit values.
> >
> > Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@xxxxxxxxxx>
> > ---
> > drivers/iio/adc/ad7768-1.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> > index 574d735f2c3a..675af9ea856d 100644
> > --- a/drivers/iio/adc/ad7768-1.c
> > +++ b/drivers/iio/adc/ad7768-1.c
> > @@ -242,6 +242,21 @@ static int ad7768_spi_reg_write(struct ad7768_state *st,
> > return spi_write(st->spi, st->data.d8, 2);
> > }
> >
> > +static int ad7768_spi_reg_write_masked(struct ad7768_state *st,
> > + unsigned int addr,
> > + unsigned int mask,
> > + unsigned int val)
> > +{
> > + unsigned int reg_val;
> > + int ret;
> > +
> > + ret = ad7768_spi_reg_read(st, addr, ®_val, 1);
> > + if (ret < 0)
> > + return ret;
> > +
> > + return ad7768_spi_reg_write(st, addr, (reg_val & ~mask) | val);
> > +}
> > +
> ad7768_spi_reg_write_masked() should be added together with at least one
> user of it otherwise it leads to build warnings.
> Though, better if able to convert to regmap as David suggested.
> regmap_set_bits() and regmap_update_bits() come for free.
>
I also think David suggestion is better, i will convert to regmap. Will
make our lives easier later as well.
> > static int ad7768_set_mode(struct ad7768_state *st,
> > enum ad7768_conv_mode mode)
> > {
> > --
> > 2.34.1
> >
