On 01/07, David Lechner wrote: > On 1/7/25 9:23 AM, Jonathan Santos wrote: > > This patch series introduces some new features, improvements, > > and fixes for the AD7768-1 ADC driver. > > > > The goal is to support all key functionalities listed in the device > > datasheet, including filter mode selection, common mode voltage > > configuration and GPIO support. Additionally, this includes fixes > > for SPI communication and for IIO interface, and also code improvements > > to enhance maintainability and readability. > > It looks like some of the patches also have to do with a sync trigger for one > or more chips. There was a recent discussion about this for another ADC that > seems relevant: > > [1]: https://lore.kernel.org/linux-iio/20241128125811.11913-1-alisa.roman@xxxxxxxxxx/ > Interesting. That would cover the case where we control the synchronization with a GPIO, but it gets more complex when using /SYNC_OUT in a multidevice setup, since it requires sending a SPI command to the "main device" to toggle the pin. The main device being the one which its /SYNC_OUT drives the others SYNC_IN. > > > > Jonathan Santos (8): > > dt-bindings: iio: adc: ad7768-1: add synchronization over SPI property > > Documentation: ABI: add wideband filter type to sysfs-bus-iio > > Documentation: ABI: testing: ad7768-1: Add device specific ABI > > documentation. > > iio: adc: ad7768-1: set MOSI idle state to high > > iio: adc: ad7768-1: use guard(mutex) to simplify code > > iio: adc: ad7768-1: add multiple scan types to support 16-bits mode > > iio: adc: ad7768-1: add support for Synchronization over SPI > > iio: adc: ad7768-1: add filter type and decimation rate attributes > > > > Sergiu Cuciurean (7): > > iio: adc: ad7768-1: Fix conversion result sign > > iio: adc: ad7768-1: Update reg_read function > > iio: adc: ad7768-1: Add reset gpio > > iio: adc: ad7768-1: Move buffer allocation to a separate function > > iio: adc: ad7768-1: Add support for variable VCM > > iio: adc: ad7768-1: Add reg_write_masked function > > iio: adc: ad7768-1: Add GPIO controller support > > > > Documentation/ABI/testing/sysfs-bus-iio | 2 + > > .../ABI/testing/sysfs-bus-iio-adc-ad7768-1 | 13 + > > .../bindings/iio/adc/adi,ad7768-1.yaml | 24 +- > > drivers/iio/adc/ad7768-1.c | 830 +++++++++++++++--- > > 4 files changed, 747 insertions(+), 122 deletions(-) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad7768-1 > > > > > > base-commit: 5de07b8a24cf44cdb78adeab790704bf577c2c1d > > What are all of these prerequisites? > I might have done something wrong while generating the pacthes, i will check this. > > prerequisite-patch-id: 8b531bca46f7c7ea1c0f6d232d162fd05fda52f7 > > prerequisite-patch-id: c8c8637cb3343097c3224a9aa315fc45dca15f45 > > prerequisite-patch-id: e0baac9ef84e6e8a0a272fc6191fc1cb48143e44 > > prerequisite-patch-id: 7e5cad70809fa7d37e917628147c197427c11594 > > prerequisite-patch-id: 28dcdb0ebc3ca3c02713f83c94a4eedbe81095dc > > ...