Re: [PATCH V3 4/8] remoteproc: qcom: add hexagon based WCSS secure PIL driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





+static int wcss_sec_start(struct rproc *rproc)
+{
+	struct wcss_sec *wcss = rproc->priv;
+	struct device *dev = wcss->dev;
+	const struct wcss_data *desc = of_device_get_match_data(dev);

Please avoid "parsing" DT in runtime.

I didn't underatand this.


IIUC, you should handle this in probe (one time) rather than for every wcss_sec_start() call. In probe, you are already fetching this data. So you can re-use the wcss->desc instead of parsing it again.




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux