On 11/01/2025 11:20, Krzysztof Kozlowski wrote: > On Fri, Jan 10, 2025 at 07:13:55AM +0100, Markus Burri wrote: >> Add new compatibility string for the epson rx8901 chip. >> The chip has input pins for tamper detection. >> This patch add a new compatibility string for this type. This is > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > >> needed to enable the functionality for this type of chip. >> >> The compatibility string is defined in the driver but not documented >> in dt-bindings. >> >> The patch also add compatibility string for epson,rx8803. >> The type is supported by the driver but not documented. > > All four sentences keep repeating the same, so just: > > "Document compatibles for RX8901 and RX8803, which are already used by > the driver." > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> I see only one was undocumented, so: "Document compatibles for: - RX8803: already used by the driver - RX8901: new device supporting also tamper detection and pinctrl ." And then you need proper pinctrl bindings :/ Best regards, Krzysztof
