RE: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid sysmgr properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Friday, 10 January, 2025 7:37 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@xxxxxxxxx>; Dinh Nguyen
> <dinguyen@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: lkp <lkp@xxxxxxxxx>
> Subject: Re: [PATCH] arm64: dts: socfpga: stratix10_swvp: remove invalid
> sysmgr properties
> 
> On 10/01/2025 12:26, niravkumar.l.rabara@xxxxxxxxx wrote:
> > From: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> >
> > Removed invalid sys-mgr properties for stratix10 and fixed
> 
> "Remove"
> 
> > dtbs_check warnings like:
> >
> > socfpga_stratix10_swvp.dtb: sysmgr@ffd12000: cpu1-start-addr: False
> > schema does not allow 4291846704 from schema $id:
> > http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
> > socfpga_stratix10_swvp.dtb: sysmgr@ffd12000: 'interrupts' does not
> > match any of the regexes: 'pinctrl-[0-9]+'
> > from schema $id:
> > http://devicetree.org/schemas/soc/altera/altr,sys-mgr.yaml#
> 
> This message is not readable. Don't wrap it.

Will fix this in v2. 
> 
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202501091748.L2W2RwE5-lkp@intel.
> > com/
> > Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@xxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > index 0d837d3e65a5..fce1dc2ebad0 100644
> > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_swvp.dts
> > @@ -110,6 +110,4 @@ &rst {
> >
> >  &sysmgr {
> >  	reg = <0xffd12000 0x1000>;
> > -	interrupts = <0x0 0x10 0x4>;
> 
> Is this correct? Some background would be useful.

stratix10_swvp.dts is for legacy Stratix10 SW Virtual Platform.
The socfpga system manager dt binding does not include "interrupt" property
and the existing socfpga board files does not use it for sysmgr.
(e.g. Cyclon5/Arria10/stratix10/Agilex)

Socfpga system manager drivers (altera-sysmgr.c/socfpga.c) also does not use
interrupt property.
The stratix10_swvp.dts has this property since beginning(unused) but 
dtbs_check warning only appeared recently when I convert system manger binding
from txt to yaml.

Thanks,
Nirav




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux