On 10/01/2025 08:33, Kever Yang wrote: >>> >>> .../devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 4 +++- >>> Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 +--- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml >>> index cc9adfc7611c..e4fcc2dff413 100644 >>> --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml >>> +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml >>> @@ -81,7 +81,9 @@ properties: >>> - const: msg >>> - const: legacy >>> - const: err >>> - - const: dma0 >>> + - enum: >>> + - msi >>> + - dma0 >> Commit msg said new interrupt, but this basically replaces existing DMA0 >> interrupt. Maybe that's the problem with this common binding and you >> just miss constraining in each device binding. If so: fix also them. > rk3588 has 9 interrupt, and the 6th-9th is dma0-3; > rk3568 only has 5 interrupts, no dma0-3; > rk3576 add one more "msi" interrupt which is the 6th interrupt; > The upcomming rk3562 is the same as rk3576. > I'm sorry I'm not so good at this yaml grammar, how should I take care > of this case? Explain this in commit msg and add proper constraints per device, e.g.: https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L127 This change for interrupts in top-level could stay. Best regards, Krzysztof
