On Mon, Apr 20, 2015 at 08:39:35AM +0100, keita kobayashi wrote: [...] > > It is related, but Mark's remark is correct. We have to keep in mind > > that an enable-method defines how a CPU is powered {up/down} and > > also suspended (quiesced through idle). > > > > It has to be defined through proper bindings and related code, adding a > > random compatible string for the sake of matching does not cut it, > > that is not acceptable and I stated it from the beginning. > > > > So, to make it clear, an enable-method defines CPU operations as a > > whole, cpu init, power{up/down} and suspend. > > > > It must be documented with proper bindings that defines compatible string and > > related properties. > > > > The sooner we incorporate the CPUidle ops into SMP ops the better to > > prevent this abuse from happening, an enable-method encompasses SMP > > ops and CPUidle ops, actually they must be merged because they represent > > the enable-method implementation as a whole. > > > > I hope this helps. > > > > Lorenzo > > > I will rename "renesas,rcar-idle" in the next patch. It is not just about renaming a compatible string, it is about defining a DT binding and related enable-method as a whole. Thanks, Lorenzo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html