On 09/01/2025 14:13, Akhil P Oommen wrote: > On 1/9/2025 1:36 PM, Krzysztof Kozlowski wrote: >> On Thu, Jan 09, 2025 at 02:10:01AM +0530, Akhil P Oommen wrote: >>> Add a new schema which extends opp-v2 to support a new vendor specific >>> property required for Adreno GPUs found in Qualcomm's SoCs. The new >>> property called "qcom,opp-acd-level" carries a u32 value recommended >>> for each opp needs to be shared to GMU during runtime. >>> >>> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. >>> >>> Cc: Rob Clark <robdclark@xxxxxxxxx> >>> Signed-off-by: Akhil P Oommen <quic_akhilpo@xxxxxxxxxxx> >>> --- >>> .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 98 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >>> new file mode 100644 >>> index 000000000000..de1f7c6c4f0e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >>> @@ -0,0 +1,97 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Adreno compatible OPP supply >>> + >>> +description: >>> + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific >>> + ACD related information tailored for the specific chipset. This binding >>> + provides the information needed to describe such a hardware value. >>> + >>> +maintainers: >>> + - Rob Clark <robdclark@xxxxxxxxx> >>> + >> >> You need select: here. See bot's warnings and other schemas, like >> primecell, how they do it. > > Somehow this error is not reproducible on my setup. I have upgraded both > Dtschema (2024.11) and and yamllint. You probably need to test all bindings, so skipping DT_SCHEMA_FILES > Anyway, could you please confirm if the below addition would be sufficient? > > select: > required: > - compatible > properties: > compatible: > contains: > const: operating-points-v2-adreno For this binding yes, but if the warning persist, then you might need to update operating-points-v2 as well, with a similar select but without "contains:". Best regards, Krzysztof
