Hi, Ryan,
On 07.01.2025 18:07, Ryan.Wanner@xxxxxxxxxxxxx wrote:
> From: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
>
> Add Device Tree for sama7d65 SoC.
>
> Co-developed-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> Signed-off-by: Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> Co-developed-by: Romain Sioen <romain.sioen@xxxxxxxxxxxxx>
> Signed-off-by: Romain Sioen <romain.sioen@xxxxxxxxxxxxx>
> Co-developed-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> Reviewed-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
> ---
> arch/arm/boot/dts/microchip/sama7d65.dtsi | 145 ++++++++++++++++++++++
> 1 file changed, 145 insertions(+)
> create mode 100644 arch/arm/boot/dts/microchip/sama7d65.dtsi
>
> diff --git a/arch/arm/boot/dts/microchip/sama7d65.dtsi b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> new file mode 100644
> index 000000000000..03e1adfdcd34
> --- /dev/null
> +++ b/arch/arm/boot/dts/microchip/sama7d65.dtsi
> @@ -0,0 +1,145 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * sama7d65.dtsi - Device Tree Include file for SAMA7D65 SoC
> + *
> + * Copyright (C) 2024 Microchip Technology, Inc. and its subsidiaries
I presume the , in "Microchip Technology, Inc." it a typo. I already
removed it while applied this. Just please let me know if all good with it.
> + *
> + * Author: Ryan Wanner <Ryan.Wanner@xxxxxxxxxxxxx>
> + *
> + */
> +
> +#include <dt-bindings/clock/at91.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/mfd/at91-usart.h>
> +
> +/ {
> + model = "Microchip SAMA7D65 family SoC";
> + compatible = "microchip,sama7d65";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + interrupt-parent = <&gic>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + compatible = "arm,cortex-a7";
> + reg = <0x0>;
> + device_type = "cpu";
> + clocks = <&pmc PMC_TYPE_CORE PMC_CPUPLL>;
> + clock-names = "cpu";
> + };
> + };
> +
> + clocks {
> + main_xtal: clock-mainxtal {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + };
> +
> + slow_xtal: clock-slowxtal {
There is an extra space in front of slow_xtal. I removed it while applying.
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + };
> +
There is an empty line here. I removed it while applying.
Everything else look good to me.
Thank you,
Claudiu
