On Wed, Jan 08, 2025 at 10:50:26AM +0800, Lei Wei wrote:
> This patch adds the following PCS functionality for the PCS driver
> for IPQ9574 SoC:
>
> a.) Parses PCS MII DT nodes and instantiate each MII PCS instance.
> b.) Exports PCS instance get and put APIs. The network driver calls
> the PCS get API to get and associate the PCS instance with the port
> MAC.
> c.) PCS phylink operations for SGMII/QSGMII interface modes.
>
> Signed-off-by: Lei Wei <quic_leiwei@xxxxxxxxxxx>
...
> +static int ipq_pcs_enable(struct phylink_pcs *pcs)
> +{
> + struct ipq_pcs_mii *qpcs_mii = phylink_pcs_to_qpcs_mii(pcs);
> + struct ipq_pcs *qpcs = qpcs_mii->qpcs;
> + int index = qpcs_mii->index;
> + int ret;
> +
> + ret = clk_prepare_enable(qpcs_mii->rx_clk);
> + if (ret) {
> + dev_err(qpcs->dev, "Failed to enable MII %d RX clock\n", index);
> + return ret;
> + }
> +
> + ret = clk_prepare_enable(qpcs_mii->tx_clk);
> + if (ret) {
> + dev_err(qpcs->dev, "Failed to enable MII %d TX clock\n", index);
> + return ret;
Hi Lei Wei,
I think you need something like the following to avoid leaking qpcs_mii->rx_clk.
goto err_disable_unprepare_rx_clk;
}
return 0;
err_disable_unprepare_rx_clk:
clk_disable_unprepare(qpcs_mii->rx_clk);
return ret;
}
Flagged by Smatch.
> + }
> +
> + return 0;
> +}
...
--
pw-bot: changes-requested
