Re: [PATCH v5 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/01/2025 09:42, Ming-Jen Chen wrote:
> 
> Krzysztof Kozlowski 於 2025/1/8 16:13 寫道:
>> On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote:
>>> From: Ming-jen Chen <mjchen0829@xxxxxxxxx>
>>>
>>> Add YAML bindings for MA35D1 SoC keypad.
>>>
>>> Signed-off-by: Ming-jen Chen <mjchen0829@xxxxxxxxx>
>>> ---
>>>   .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++
>>>   1 file changed, 82 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>>> new file mode 100644
>>> index 000000000000..889f253b3bc2
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>> I don't see changes.
>>
>> I already raised concern that you sent new versions without implementing
>> or responding to comments. So the fourth (!!!) time: Filename matching
>> compatible.
>>
>> Best regards,
>> Krzysztof
> 
> Thank you for your feedback! I now understand the changes I need to make.
> 
> I will modify it as blow:
> 
>    compatible:
>      const: nuvoton,ma35d1-keypad

Or change the filename...

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux