On Tue, Jan 07, 2025 at 01:35:10PM +0200, Ivaylo Ivanov wrote: > Add new constants for choosing the additional USIv1 configuration modes > in device tree. Those are further used in the USI driver to figure out > which value to write into SW_CONF register. Modify the current USI IP-core > bindings to include information about USIv1 and a compatible for > exynos8895. > > In the original bindings commit, protocol mode definitions were named > with the version of the supported USI (in this case, V2) with the idea of > leaving enough room in the future for other versions of this block. This, > however, is not how the modes should be modelled. The modes are not > version specific and you should not be able to tell USI which version of > a mode to use - that has to be handled in the driver - thus encoding this > information in the binding is meaningless. Only one constant per mode is > needed, so while we're at it, add new constants with the prefix USI_MODE > and mark the old ones as depracated. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx> > --- > .../bindings/soc/samsung/exynos-usi.yaml | 99 ++++++++++++------- > include/dt-bindings/soc/samsung,exynos-usi.h | 17 +++- > 2 files changed, 79 insertions(+), 37 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
