On 11/29/2024 7:30 PM, Konrad Dybcio wrote:
On 29.11.2024 12:14 PM, Konrad Dybcio wrote:
On 26.11.2024 10:35 AM, Tingguo Cheng wrote:
Enable PMIC and PMIC peripherals for qcs8300-ride board. The qcs8
300-ride uses 2 pmics(pmm8620au:0,pmm8650au:1) on the board, which
are variants of pmm8654au used on sa8775p/qcs9100 -ride(4x pmics).
Signed-off-by: Tingguo Cheng <quic_tingguoc@xxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index 7eed19a694c39dbe791afb6a991db65acb37e597..9447efb9cd01654b74ec4c18dec58b1956ffe710 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -9,6 +9,7 @@
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "qcs8300.dtsi"
+#include "sa8775p-pmics.dtsi"
/ {
model = "Qualcomm Technologies, Inc. QCS8300 Ride";
compatible = "qcom,qcs8300-ride", "qcom,qcs8300";
@@ -223,6 +224,28 @@ &gcc {
<0>;
};
+&pmm8654au_0_pon_resin{
+ linux,code = <KEY_VOLUMEDOWN>;
+
+ status = "okay";
+};
+
+&pmm8654au_2{
+ status = "disabled";
+};
+
+&pmm8654au_2_thermal{
+ status = "disabled";
+};
+
+&pmm8654au_3{
+ status = "disabled";
+};
+
+&pmm8654au_3_thermal{
+ status = "disabled";
+};
Are all these PMICs absent?
>
Yes, sa8775p/qcs9100 -ride devices get 4 pmics inside, but qcs8300-ride
gets only 2 pmics inside(0 and 1). So pmm8654au_2 and pmm8654au_3 are
going to be removed to align with the board configuration.
OK I re-read the commit message..
Disabling a lot of things usually points to a backwards approach,
are there any other PMICs on board?
>
No any other PMICs on board. There are only 2 PMICs on this type of
board. And the 2 PMICs is the variant of the PMICs used on
sa8775p/qcs9100 -ride. From this perspective, just like qcs615-ride
device, so I reused the original xxx-pmics.dtsi to reflect the
relationship of "variant".
Konrad
--
Thank you & BRs
Tingguo