Hello Chen-Yu,
On Sat, Dec 21, 2024 at 12:12:40AM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@xxxxxxxx>
>
> The Orange Pi 5 Plus has its first USB 3.0 interface on the SoC wired
> directly to the USB type C port next to the MASKROM button, and the
> second interface wired to a USB 3.0 hub which in turn is connected to
> the USB 3.0 host ports on the board, as well as the USB 2.0 connection
> on the M.2 E-key slot.
>
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
>
> ---
> Changes since v1:
> - Dropped source current to 1.4A
> - Dropped sink current to 10mA, since it doesn't actually sink current
> - Added try-power-role
> - Added newline before endpoint device nodes in USB connector node
> ---
> .../dts/rockchip/rk3588-orangepi-5-plus.dts | 133 ++++++++++++++++++
> 1 file changed, 133 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> index 9f5a38b290bf..000d353645a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
> @@ -218,6 +218,18 @@ vcc5v0_sys: regulator-vcc5v0-sys {
> regulator-max-microvolt = <5000000>;
> };
>
> + vbus5v0_typec: vbus-typec-regulator {
I think the new policy is to prefix with 'regulator-' so eg.:
vbus5v0_typec: regulator-vbus5v0-typec
With that:
Reviewed-by: Ondrej Jirman <megi@xxxxxx>
thank you,
o.
