Hello Rob,
Thanks for the review. Sorry for the late reply due to vacation.
On 12/16/24 10:29, Rob Herring (Arm) wrote:
On Fri, 13 Dec 2024 08:50:26 -0600, Ninad Palsule wrote:
Hello
Please review the patch set. It has various device tree changes for
system1 BMC after hardware testing.
NINAD PALSULE (7):
ARM: dts: aspeed: system1: Add IPMB device
ARM: dts: aspeed: system1: Add GPIO line name
ARM: dts: aspeed: system1: Add RGMII support
ARM: dts: aspeed: system1: Reduce sgpio speed
ARM: dts: aspeed: system1: Update LED gpio name
ARM: dts: aspeed: system1: Remove VRs max8952
ARM: dts: aspeed: system1: Mark GPIO line high/low
Ninad Palsule (1):
ARM: dts: aspeed: system1: Disable gpio pull down
.../dts/aspeed/aspeed-bmc-ibm-system1.dts | 178 ++++++++++++------
1 file changed, 119 insertions(+), 59 deletions(-)
--
2.43.0
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20241213145037.3784931-1-ninad@xxxxxxxxxxxxx:
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: ethernet@1e660000: phy-mode:0: 'rgmii-rxid' is not one of ['rgmii', 'rmii']
from schema $id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#
Added rgmii-rxid mode in the yaml file.
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: gpio@1e780000: 'fan_controller_reset', 'isolate_errs_cpu1', 'rtc_reset', 'srtc_reset' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
I am still not sure about this error.
/home/ninad/dev/sbp1/linux/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb:
gpio@1e780000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of
the regexes: 'pinctrl-[0-9]+'
from schema $id:
http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: rtc_reset: $nodename:0: 'rtc_reset' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-hog.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: srtc_reset: $nodename:0: 'srtc_reset' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-hog.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: fan_controller_reset: $nodename:0: 'fan_controller_reset' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-hog.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: isolate_errs_cpu1: $nodename:0: 'isolate_errs_cpu1' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-hog.yaml#
Changed to generic name hog-0...3
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: /ahb/apb@1e780000/bus@1e78a000/i2c@280/bmc_slave@10: failed to match any schema with compatible: ['ipmb-dev']
Documented IPMB device interface.
Regards,
Ninad