Hello Frank,
On 19.12.24 20:24, Frank Li wrote:
> On Thu, Dec 19, 2024 at 06:45:24PM +0100, Ahmad Fatoum wrote:
>> On 19.12.24 18:37, Frank Li wrote:
>>> On Thu, Dec 19, 2024 at 08:25:30AM +0100, Ahmad Fatoum wrote:
>>>> From: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>>>>
>>>> The Skov i.MX8MP LT6 device tree so far described the touch screen, but
>>>> didn't describe the screen itself. Fill out these missing pieces.
>>>
>>> Add "ti,sn65lvds822" touch screen description for i.MX8MP LT6 board.
>>
>> This is not what this patch does. Touch screen was already described
>> and now the remainder is being added, just like what my message said.
>
> My main means, use below order to descript commit message
>
> Add ... for ...
Sorry, I won't start every sentence with a verb. The commit message
is fine IMO.
Thanks,
Ahmad
>
> Frank
>
>>
>> Thanks,
>> Ahmad
>>
>>>
>>> Frank
>>>
>>>> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>>>> Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
>>>> ---
>>>> .../boot/dts/freescale/imx8mp-skov-revb-lt6.dts | 60 ++++++++++++++++++++++
>>>> 1 file changed, 60 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-lt6.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-lt6.dts
>>>> index ccbd3abedd69..baecf768a2ee 100644
>>>> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-lt6.dts
>>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-lt6.dts
>>>> @@ -8,6 +8,45 @@ / {
>>>> model = "SKOV IMX8MP CPU revB - LT6";
>>>> compatible = "skov,imx8mp-skov-revb-lt6", "fsl,imx8mp";
>>>>
>>>> + lvds-decoder {
>>>> + compatible = "ti,sn65lvds822", "lvds-decoder";
>>>> + power-supply = <®_3v3>;
>>>> +
>>>> + ports {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + port@0 {
>>>> + reg = <0>;
>>>> +
>>>> + in_lvds1: endpoint {
>>>> + data-mapping = "vesa-24";
>>>> + remote-endpoint = <&ldb_lvds_ch1>;
>>>> + };
>>>> + };
>>>> +
>>>> + port@1 {
>>>> + reg = <1>;
>>>> +
>>>> + lvds_decoder_out: endpoint {
>>>> + remote-endpoint = <&panel_in>;
>>>> + };
>>>> + };
>>>> + };
>>>> + };
>>>> +
>>>> + panel {
>>>> + compatible = "logictechno,lttd800480070-l6wh-rt";
>>>> + backlight = <&backlight>;
>>>> + power-supply = <®_tft_vcom>;
>>>> +
>>>> + port {
>>>> + panel_in: endpoint {
>>>> + remote-endpoint = <&lvds_decoder_out>;
>>>> + };
>>>> + };
>>>> + };
>>>> +
>>>> touchscreen {
>>>> compatible = "resistive-adc-touch";
>>>> io-channels = <&adc_ts 1>, <&adc_ts 3>, <&adc_ts 4>, <&adc_ts 5>;
>>>> @@ -78,6 +117,27 @@ channel@5 {
>>>> };
>>>> };
>>>>
>>>> +&lcdif2 {
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> +&lvds_bridge {
>>>> + assigned-clocks = <&clk IMX8MP_CLK_MEDIA_LDB>,
>>>> + <&clk IMX8MP_VIDEO_PLL1>;
>>>> + assigned-clock-parents = <&clk IMX8MP_VIDEO_PLL1_OUT>;
>>>> + /* IMX8MP_VIDEO_PLL1 = IMX8MP_CLK_MEDIA_DISP2_PIX * 2 * 7 */
>>>> + assigned-clock-rates = <0>, <462000000>;
>>>> + status = "okay";
>>>> +
>>>> + ports {
>>>> + port@2 {
>>>> + ldb_lvds_ch1: endpoint {
>>>> + remote-endpoint = <&in_lvds1>;
>>>> + };
>>>> + };
>>>> + };
>>>> +};
>>>> +
>>>> &pwm1 {
>>>> status = "okay";
>>>> };
>>>>
>>>> --
>>>> 2.39.5
>>>>
>>>
>>
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
