hi, On Wed, 2024-11-27 at 08:26 -0600, Rob Herring wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > On Tue, Nov 26, 2024 at 10:58:58AM +0800, Chunfeng Yun wrote: > > Add a property to tune usb2 phy's disconnect threshold. > > And add a compatible for mt8196. > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml | 8 > > ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > > b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > > index a9e3139fd421..2e012d5e1da1 100644 > > --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml > > @@ -49,6 +49,7 @@ properties: > > - enum: > > - mediatek,mt3611-xsphy > > - mediatek,mt3612-xsphy > > + - mediatek,mt8196-xsphy > > - const: mediatek,xsphy > > > > reg: > > @@ -129,6 +130,13 @@ patternProperties: > > minimum: 1 > > maximum: 7 > > > > + mediatek,discth: > > That's not understandable. Spell it out: mediatek,disconnect-thres It comes from xsphy register map document, due to xsphy is similar with t-phy, I port it from t-phy, and use the same property. https://elixir.bootlin.com/linux/v6.13-rc3/source/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml#L226 Thanks. > > > + description: > > + The selection of disconnect threshold (U2 phy) > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + minimum: 1 > > + maximum: 15 > > + > > mediatek,efuse-intr: > > description: > > The selection of Internal Resistor (U2/U3 phy) > > -- > > 2.46.0 > >