On 20.12.24 07:12, kernel test robot wrote: > Hi Ahmad, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8] > > url: https://github.com/intel-lab-lkp/linux/commits/Ahmad-Fatoum/reboot-replace-__hw_protection_shutdown-bool-action-parameter-with-an-enum/20241219-155416 > base: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8 > patch link: https://lore.kernel.org/r/20241219-hw_protection-reboot-v1-2-263a0c1df802%40pengutronix.de > patch subject: [PATCH 02/11] reboot: reboot, not shutdown, on hw_protection_reboot timeout > config: i386-buildonly-randconfig-003-20241220 (https://download.01.org/0day-ci/archive/20241220/202412201310.JWkUQ9qf-lkp@xxxxxxxxx/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241220/202412201310.JWkUQ9qf-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202412201310.JWkUQ9qf-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > kernel/reboot.c:241: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart' >>> kernel/reboot.c:995: warning: Function parameter or struct member 'action' not described in 'hw_failure_emergency_schedule' >>> kernel/reboot.c:995: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_schedule' Will fix the kernel doc issues for v2. > kernel/reboot.c:1023: warning: Function parameter or struct member 'action' not described in '__hw_protection_shutdown' > kernel/reboot.c:1023: warning: Excess function parameter 'shutdown' description in '__hw_protection_shutdown' > > > vim +995 kernel/reboot.c > > dfa19b11385d4c Matti Vaittinen 2021-06-03 983 > dfa19b11385d4c Matti Vaittinen 2021-06-03 984 static DECLARE_DELAYED_WORK(hw_failure_emergency_poweroff_work, > dfa19b11385d4c Matti Vaittinen 2021-06-03 985 hw_failure_emergency_poweroff_func); > dfa19b11385d4c Matti Vaittinen 2021-06-03 986 > dfa19b11385d4c Matti Vaittinen 2021-06-03 987 /** > 595ab92650cc28 Ahmad Fatoum 2024-12-19 988 * hw_failure_emergency_schedule - Schedule an emergency system shutdown or reboot > dfa19b11385d4c Matti Vaittinen 2021-06-03 989 * > dfa19b11385d4c Matti Vaittinen 2021-06-03 990 * This may be called from any critical situation to trigger a system shutdown > dfa19b11385d4c Matti Vaittinen 2021-06-03 991 * after a given period of time. If time is negative this is not scheduled. > dfa19b11385d4c Matti Vaittinen 2021-06-03 992 */ > 595ab92650cc28 Ahmad Fatoum 2024-12-19 993 static void hw_failure_emergency_schedule(enum hw_protection_action action, > 595ab92650cc28 Ahmad Fatoum 2024-12-19 994 int poweroff_delay_ms) > dfa19b11385d4c Matti Vaittinen 2021-06-03 @995 { > dfa19b11385d4c Matti Vaittinen 2021-06-03 996 if (poweroff_delay_ms <= 0) > dfa19b11385d4c Matti Vaittinen 2021-06-03 997 return; > 595ab92650cc28 Ahmad Fatoum 2024-12-19 998 hw_failure_emergency_action = action; > dfa19b11385d4c Matti Vaittinen 2021-06-03 999 schedule_delayed_work(&hw_failure_emergency_poweroff_work, > dfa19b11385d4c Matti Vaittinen 2021-06-03 1000 msecs_to_jiffies(poweroff_delay_ms)); > dfa19b11385d4c Matti Vaittinen 2021-06-03 1001 } > dfa19b11385d4c Matti Vaittinen 2021-06-03 1002 > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
