On Thu, Jan 02, 2025 at 04:56:44AM +0800, kernel test robot wrote: > Hi Manivannan, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on 40384c840ea1944d7c5a392e8975ed088ecf0b37] > > url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam-via-B4-Relay/regulator-Guard-of_regulator_bulk_get_all-with-CONFIG_OF/20241231-174751 > base: 40384c840ea1944d7c5a392e8975ed088ecf0b37 > patch link: https://lore.kernel.org/r/20241231-pci-pwrctrl-slot-v2-6-6a15088ba541%40linaro.org > patch subject: [PATCH v2 6/6] PCI/pwrctrl: Add pwrctrl driver for PCI Slots > config: x86_64-randconfig-074-20250102 (https://download.01.org/0day-ci/archive/20250102/202501020407.HmQQQKa0-lkp@xxxxxxxxx/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250102/202501020407.HmQQQKa0-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202501020407.HmQQQKa0-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > drivers/pci/pwrctrl/slot.c: In function 'pci_pwrctrl_slot_probe': > >> drivers/pci/pwrctrl/slot.c:39:15: error: implicit declaration of function 'of_regulator_bulk_get_all'; did you mean 'regulator_bulk_get'? [-Werror=implicit-function-declaration] > 39 | ret = of_regulator_bulk_get_all(dev, dev_of_node(dev), > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > | regulator_bulk_get Sigh! The driver was built with !CONFIG_REGULATOR. This requires fixing 'include/linux/regulator/consumer.h'. Will add it in next iteration. - Mani > cc1: some warnings being treated as errors > > > vim +39 drivers/pci/pwrctrl/slot.c > > 28 > 29 static int pci_pwrctrl_slot_probe(struct platform_device *pdev) > 30 { > 31 struct pci_pwrctrl_slot_data *slot; > 32 struct device *dev = &pdev->dev; > 33 int ret; > 34 > 35 slot = devm_kzalloc(dev, sizeof(*slot), GFP_KERNEL); > 36 if (!slot) > 37 return -ENOMEM; > 38 > > 39 ret = of_regulator_bulk_get_all(dev, dev_of_node(dev), > 40 &slot->supplies); > 41 if (ret < 0) { > 42 dev_err_probe(dev, ret, "Failed to get slot regulators\n"); > 43 return ret; > 44 } > 45 > 46 slot->num_supplies = ret; > 47 ret = regulator_bulk_enable(slot->num_supplies, slot->supplies); > 48 if (ret < 0) { > 49 dev_err_probe(dev, ret, "Failed to enable slot regulators\n"); > 50 goto err_regulator_free; > 51 } > 52 > 53 ret = devm_add_action_or_reset(dev, devm_pci_pwrctrl_slot_power_off, > 54 slot); > 55 if (ret) > 56 goto err_regulator_disable; > 57 > 58 pci_pwrctrl_init(&slot->ctx, dev); > 59 > 60 ret = devm_pci_pwrctrl_device_set_ready(dev, &slot->ctx); > 61 if (ret) > 62 return dev_err_probe(dev, ret, "Failed to register pwrctrl driver\n"); > 63 > 64 return 0; > 65 > 66 err_regulator_disable: > 67 regulator_bulk_disable(slot->num_supplies, slot->supplies); > 68 err_regulator_free: > 69 regulator_bulk_free(slot->num_supplies, slot->supplies); > 70 > 71 return ret; > 72 } > 73 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki -- மணிவண்ணன் சதாசிவம்
