On Fri, Apr 10, 2015 at 04:14:08PM +0800, Koro Chen wrote:
> +/*
> + * The MTK AFE unit has a audio interconnect with MTK_AFE_INTERCONN_NUM_INPUT
> + * inputs and MTK_AFE_INTERCONN_NUM_OUTPUT outputs. Below table holds the
> + * register/bits to set to connect an input with an output.
> + */
> +static const struct mtk_afe_connection
> + connections[MTK_AFE_INTERCONN_NUM_INPUT][MTK_AFE_INTERCONN_NUM_OUTPUT] = {
> + [0][0] = { .creg = 0x020, .cshift = 0, .sreg = 0x020, .sshift = 10},
> + [0][1] = { .creg = 0x020, .cshift = 16, .sreg = 0x020, .sshift = 26},
What are the constraints on using this - is it one input to one output
only or can we do mixing or duplication? The register interface
definitely does look like something asking for runtime configuration.
It'd also be nice to have less magic numbers in the table, at least for
the indexes (which I guess correspond to some of the defines in the
headers)?
Attachment:
signature.asc
Description: Digital signature
