On 12/13/2024 1:04 AM, Konrad Dybcio wrote: > On 10.12.2024 9:23 AM, Yuanfang Zhang wrote: >> Add coresight components: Funnel, ETE and ETF for SM8650. >> >> Signed-off-by: Yuanfang Zhang <quic_yuanfang@xxxxxxxxxxx> >> --- >> Changes in v2: >> - Update compatible for funnel and etf. >> - remove unnecessary property: reg-names and arm,primecell-periphid. >> - Link to v1: https://lore.kernel.org/r/20241210-sm8650-cs-dt-v1-1-269693451584@xxxxxxxxxxx >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 165 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 165 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> index 25e47505adcb790d09f1d2726386438487255824..76620d478e872a2b725693dc32364e2a183572b7 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> @@ -5654,6 +5654,171 @@ compute-cb@12 { >> }; >> }; >> }; >> + >> + ete0 { >> + compatible = "arm,embedded-trace-extension"; >> + >> + cpu = <&cpu0>; >> + qcom,skip-power-up; >> + >> + out-ports { >> + port { >> + ete0_out_funnel_ete: endpoint { >> + remote-endpoint = <&funnel_ete_in_ete0>; >> + }; >> + }; >> + }; >> + }; >> + >> + funnel_ete { > > Node names must not contain underscores, use '-' instead As node name pattern: "^ete([0-9a-f]+)$" in arm,embedded-trace-extension.yaml, then name it ete0. > > Also, nodes without a reg property/unit address don't belong under /soc > Done. > Konrad
