On Fri, 2015-04-17 at 22:07 +0200, Arnd Bergmann wrote: > On Friday 17 April 2015 09:50:56 Jens Wiklander wrote: > > +static const struct file_operations tee_fops = { > > + .owner = THIS_MODULE, > > + .open = tee_open, > > + .release = tee_release, > > + .unlocked_ioctl = tee_ioctl > > +}; > > Add a .compat_ioctl function, to make it work on arm64 as well. > If you got all the data structures right, you can use the same > tee_ioctl function. > > Minor nit: put a comma behind the last line in each struct initialization > to make it easier to add another callback. And another nit: this is built-in only code, right? So, according to include/linux/export.h, THIS_MODULE will be basically equivalent to NULL. So I think you can drop that line. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html