Le 23/12/2024 à 17:42, Mathieu Dubois-Briand a écrit :
Add driver for Maxim Integrated MAX7360 keypad controller, providing
support for up to 64 keys, with a matrix of 8 columns and 8 rows.
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@xxxxxxxxxxx>
...
+static int max7360_keypad_open(struct input_dev *pdev)
+{
+ struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev);
+ int error;
+
+ /*
+ * Somebody is using the device: get out of sleep.
+ */
+ error = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG,
+ MAX7360_CFG_SLEEP, MAX7360_CFG_SLEEP);
+ if (error) {
+ dev_err(&max7360_keypad->input->dev,
+ "Failed to write max7360 configuration");
Missing \n.
+ return error;
+ }
+
+ return 0;
+}
+
+static void max7360_keypad_close(struct input_dev *pdev)
+{
+ struct max7360_keypad *max7360_keypad = input_get_drvdata(pdev);
+ int error;
+
+ /*
+ * Nobody is using the device anymore: go to sleep.
+ */
+ error = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_CONFIG,
+ MAX7360_CFG_SLEEP, ~MAX7360_CFG_SLEEP);
+ if (error)
+ dev_err(&max7360_keypad->input->dev,
+ "Failed to write max7360 configuration");
Missing \n.
+}
+
+static int max7360_keypad_hw_init(struct max7360_keypad *max7360_keypad)
+{
+ unsigned int val;
+ int error;
+
+ val = max7360_keypad->debounce_ms - MAX7360_DEBOUNCE_MIN;
+ error = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_DEBOUNCE,
+ MAX7360_DEBOUNCE,
+ FIELD_PREP(MAX7360_DEBOUNCE, val));
+ if (error) {
+ dev_err(&max7360_keypad->input->dev,
+ "Failed to write max7360 debounce configuration");
Missing \n.
This is called from probe. Use dev_err_rpobe()?
+ return error;
+ }
+
+ error = regmap_write_bits(max7360_keypad->regmap, MAX7360_REG_INTERRUPT,
+ MAX7360_INTERRUPT_TIME_MASK,
+ FIELD_PREP(MAX7360_INTERRUPT_TIME_MASK, 1));
+ if (error) {
+ dev_err(&max7360_keypad->input->dev,
+ "Failed to write max7360 keypad interrupt configuration");
Missing \n.
This is called from probe. Use dev_err_rpobe()?
+ return error;
+ }
+
+ return 0;
+}
...
+static int max7360_keypad_probe(struct platform_device *pdev)
+{
+ struct max7360_keypad *max7360_keypad;
+ struct input_dev *input;
+ bool autorepeat;
+ int error;
+ int irq;
+
+ if (!pdev->dev.parent)
+ return dev_err_probe(&pdev->dev, -ENODEV, "No parent device\n");
+
+ irq = platform_get_irq_byname(to_platform_device(pdev->dev.parent),
+ "intk");
+ if (irq < 0)
+ return irq;
+
+ max7360_keypad = devm_kzalloc(&pdev->dev, sizeof(*max7360_keypad),
+ GFP_KERNEL);
+ if (!max7360_keypad)
+ return -ENOMEM;
+
+ max7360_keypad->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ if (!max7360_keypad->regmap)
+ return dev_err_probe(&pdev->dev, -ENODEV,
+ "Could not get parent regmap\n");
+
+ error = max7360_keypad_parse_dt(pdev, max7360_keypad, &autorepeat);
+ if (error)
+ return error;
+
+ input = devm_input_allocate_device(pdev->dev.parent);
+ if (!input)
+ return dev_err_probe(&pdev->dev, -ENOMEM,
+ "Failed to allocate input device\n");
Not sure an error message is needed.
+
+ max7360_keypad->input = input;
+
+ input->id.bustype = BUS_I2C;
+ input->name = pdev->name;
+ input->open = max7360_keypad_open;
+ input->close = max7360_keypad_close;
+
+ error = matrix_keypad_build_keymap(NULL, NULL,
+ MAX7360_MAX_KEY_ROWS,
+ MAX7360_MAX_KEY_COLS,
+ max7360_keypad->keycodes, input);
+ if (error)
+ return dev_err_probe(&pdev->dev, error,
+ "Failed to build keymap\n");
+
+ input_set_capability(input, EV_MSC, MSC_SCAN);
+ if (autorepeat)
+ __set_bit(EV_REP, input->evbit);
+
+ input_set_drvdata(input, max7360_keypad);
+
+ error = devm_request_threaded_irq(&pdev->dev, irq, NULL,
+ max7360_keypad_irq,
+ IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+ "max7360-keypad", max7360_keypad);
+ if (error)
+ return dev_err_probe(&pdev->dev, error,
+ "Failed to register interrupt: %d\n",
+ error);
No need to duplicate error.
+
+ error = input_register_device(input);
+ if (error)
+ return dev_err_probe(&pdev->dev, error,
+ "Could not register input device: %d\n",
+ error);
No need to duplicate error.
+
+ platform_set_drvdata(pdev, max7360_keypad);
+
+ error = max7360_keypad_hw_init(max7360_keypad);
+ if (error)
+ return dev_err_probe(&pdev->dev, error,
+ "Failed to initialize max7360 keypad\n");
+
+ device_init_wakeup(&pdev->dev, true);
+ error = dev_pm_set_wake_irq(&pdev->dev, irq);
+ if (error)
+ dev_warn(&pdev->dev, "Failed to set up wakeup irq: %d\n",
+ error);
+
+ return 0;
+}
CJ
