Re: [PATCH 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Arnd,

2015-04-16 18:44 GMT+09:00 Arnd Bergmann <arnd@xxxxxxxx>:
> On Thursday 16 April 2015 16:40:37 Masahiro Yamada wrote:
>> +
>> +/ {
>> +     model = "UniPhier PH1-LD4 Reference Board";
>> +     compatible = "socionext,ph1-ld4-ref", "socionext,ph1-ld4";
>> +
>> +     memory {
>> +             device_type = "memory";
>> +             reg = <0x80000000 0x20000000>;
>> +     };
>> +
>> +     chosen {
>> +             bootargs = "console=ttyS0,115200 earlyprintk";
>> +     };
>
> I would remove the 'earlyprintk' option here. You don't add any options
> for the platform in Kconfig.debug, and I hope that we can eventually
> start using earlycon. Please add an appropriate stdio-path property
> here, but note that we are still lacking the fixmap patches to make
> earlycon work.
>
> Otherwise looks good.

I dropped earlyprintk, added stdout-path in v3.

Thanks!


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux