On 30/12/2024 23:12, Paul Handrigan wrote: > Add device tree support for the Cirrus Logic CS2600 clock > device. > > Signed-off-by: Paul Handrigan <paulha@xxxxxxxxxxxxxxxxxxxxx> I was wondering why this is not picked up by my filters... now I now: wrong subject prefix. It's dt-bindings. > --- > .../bindings/clock/cirrus,cs2600.yaml | 99 +++++++++++++++++++ > 1 file changed, 99 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml > > diff --git a/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml b/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml > new file mode 100644 > index 000000000000..c6f216e45791 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml > @@ -0,0 +1,99 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/cirrus,cs2600.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cirrus Logic Fractional-N Clock Synthesizer & Clock Multiplier > + > +maintainers: > + - Paul Handrigan <paulha@xxxxxxxxxxxxxxxxxxxxx> > + - patches@xxxxxxxxxxxxxxxxxxxxx> > + > +description: > + The CS2600 is a system-clocking device that enables frequency synthesis and > + clock generation from a stable timing reference clock. The device can > + generate low-jitter clocks from a noisy clock reference at frequencies > + as low as 50 Hz. The device has two potental clock inputs (xti and clk_in) > + where xti can either be a crystal or a constant refclk and the clk_in. The > + device can have either xti, clk_in, or both as a clock input depending on > + the usecase. It also has three possible outputs CLK_OUT, BCLK_OUT, and > + FSYNC_OUT. > + > +properties: > + compatible: > + enum: > + - cirrus,cs2600 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 This does not match clock-names. Missing minItems. I already commented on this last time. Implement all comments I asked for. > + > + clock-names: > + items: > + enum: > + - xti > + - clk_in > + minItems: 1 > + maxItems: 2 > + > + '#clock-cells': > + const: 1 > + > + vdd-supply: > + description: Power Supply > + > + clock-output-names: > + maxItems: 3 > + description: Names for CLK_OUT, BCLK_OUT and FSYNC_OUT clocks. > + > + cirrus,aux-output-source: > + description: > + Specifies the function of the auxiliary output pin with "phase_unlock" > + to indicate the input and output clocks are not in phase, "freq_unlock" > + to indicate the PLL is unlocked, and "no_clkin" to indicate the clock on > + the clk_in pin is not present. > + $ref: /schemas/types.yaml#/definitions/string > + enum: > + - phase_unock # Sets output pin to indicate PHASE_UNLOCK > + - freq_unlock # Sets output pin to indicate FREQ_UNLOCK > + - no_clkin # Sets output pin to indicate NO_CLKIN Drop comments, you just repeated the value. If you want to add comment, say something different than the value is saying. Best regards, Krzysztof
