> > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + enum: > > + - xti > > + - clk_in > > + minItems: 1 > > + maxItems: 2 > > This does not match clocks. Nothing here, neither commit msg nor > description, explains why this is so flexible. I will add more detial into the discription. You can have one of xti and clk_in as clock sources or both. > > + reg: > > + maxItems: 1 > > Keep the same order of properties as in required list. Ack > > + clock-output-names: > > + maxItems: 3 > > + description: Names for CLK_OUT, BCLK_OUT and FSYNC_OUT clocks. > > + > > + cirrus,aux-output-source: > > + description: > > + Specifies the function of the auxiliary output pin with "PHASE_UNLOCK" > > + to indicate the input and output clocks are not in phase, "FREQ_UNLOCK" > > + to indicate the PLL is unlocked, and NO_CLKIN to indicate the clock on > > + the clk_in pin is not present. > > enum and lower-case I'll change this back to an enum with lower-case strings as the input. > > > + $ref: /schemas/types.yaml#/definitions/string > > + > > + cirrus,clock-mode: > > + description: > > + Sets the device into smart mode whith "SMART_MODE" and sets the device > > + into smart mode that only outputs a clock when clk_in starts with > > + "SMART_CLKIN_ONLY_MODE". > > enum and lower-case Ack > > + > > +unevaluatedProperties: false > > This is supposed to be additionalProperties. See example-schema. Ack > > > + > > +examples: > > + - | > > + > > Drop blank line Ack Regards, Paul