Hi Xianwei, On Thu, Dec 26, 2024 at 8:57 AM Xianwei Zhao via B4 Relay <devnull+xianwei.zhao.amlogic.com@xxxxxxxxxx> wrote: [...] > + if (of_property_read_u32(np, "mask", &bank->pc.mux_mask)) > + bank->pc.mux_mask = 0xf; I don't see any documentation for the mask property. The discussion about the dt-bindings is still pretty heated. Everything else is already part of the documentation (which is good!). Please document his property as well (or remove the code to read it if there's no need to have it dynamic). This is not a full code-review. However, since the discussion about the whole dt-bindings is still ongoing we need to make sure that whatever we document in the bindings is actually all that we need to write the driver. Best regards, Martin
