On Thu, Dec 26, 2024 at 05:54:15PM +0100, Ahmad Fatoum wrote: > Hi Conor, > > On 25.12.24 15:20, Conor Dooley wrote: > > On Thu, Dec 19, 2024 at 09:14:10PM +0100, Ahmad Fatoum wrote: > >> On 19.12.24 20:49, Conor Dooley wrote: > >>> On Thu, Dec 19, 2024 at 08:27:32AM +0100, Ahmad Fatoum wrote: > >> Theoretically, we could infer mode at runtime from VDD_SOC voltage, > >> but we need to set up clocks to read out the PMIC and I want to > >> apply the constraints as early as possible as I don't want the SoC > >> to run outside of spec even for a short while. > > > > Apologies for the delay responding to you, doing it today cos I feel > > guilty! > > I am fully aware that I needn't expect prompt review feedback so late in > December. Thanks a lot for taking the time still. I guess, but I /had/ replied to other things that came in after your mail, which is where my guilt comes from! > > I think what you've explained here is fine, but could you add a > > bit more of that info to the commit message, explaining why one cannot > > be default? With that, > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Thanks. I will await further review feedback and adjust this commit's > message for v2 as requested. > > Wishing you nice holidays, You too (or what's left of em at least).
Attachment:
signature.asc
Description: PGP signature
